refactor(gui): drop Review page + normalization gate
Home is now the only entry point: the "Run analysis" button on the upload section IS the review step (findings render inline via render_findings_panel). Tool pages no longer gate on a passed normalization — running the analyzer is sufficient context. Removed: - src/gui/pages/0_Review.py - src/gui/components/gate.py (re-export seam) - require_normalization_gate() in src/gui/components/_legacy.py - "review" section enum in tools_registry.py - Data Review entry in app.py navigation - require_normalization_gate() calls + imports in all nine tool pages - tests/gui/test_gate.py (whole file) - TestReviewWorkflow in tests/gui/test_workflows.py - 0_Review entry in tests/gui/test_smoke.py PAGE_SLUGS - stash_upload's normalization_result+normalization_for stashing - stash_upload_without_gate (was the gate's negative-path helper) 2017 tests pass (16 retired with the gate flow). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -25,7 +25,6 @@ from .conftest import collected_text, with_language
|
||||
# Every page that ships in the sidebar nav. Slugs match the filenames
|
||||
# under ``src/gui/pages/`` so failures point at a real file.
|
||||
PAGE_SLUGS = [
|
||||
"0_Review",
|
||||
"1_Deduplicator",
|
||||
"2_Text_Cleaner",
|
||||
"3_Format_Standardizer",
|
||||
@@ -53,7 +52,6 @@ PAGE_SLUGS = [
|
||||
# When a page gains real Spanish translation, flip its 'es' entry to
|
||||
# the localized substring — the test surface stays the same.
|
||||
EXPECTED_SUBSTRINGS: dict[str, dict[str, str]] = {
|
||||
"0_Review": {"en": "Review", "es": "Review"},
|
||||
"1_Deduplicator": {"en": "Find Duplicates", "es": "Find Duplicates"},
|
||||
"2_Text_Cleaner": {"en": "Clean Text", "es": "Clean Text"},
|
||||
"3_Format_Standardizer": {"en": "Standardize", "es": "Standardize"},
|
||||
|
||||
Reference in New Issue
Block a user