feat(analyze,ui): recommend Standardize Formats + bold red Open buttons
Two reported issues addressed together because they're the same UX flow (home findings panel → jump to relevant tool). (1) Format-Standardizer recommendations weren't firing. Reported: uploading a file from the format-cleaner test corpus (``24_format_dates.csv``, ``25_format_phones.csv``, ``29_format_currencies.csv``, ``30_format_integration.csv``) showed zero "Standardize Formats" recommendations even though the columns clearly mixed multiple date / phone / currency formats. Two underlying causes: - ``_detect_inconsistent_date_format`` required two MATCHES per distinct format. A test column with N rows each in a different format had ≤1 match per format and was silently passed over. Loosened to "≥1 match per format" — the inconsistency signal is the presence of ≥2 distinct formats, not their volume. - Only date inconsistency was detected. Phones, currency, and booleans (the other format-standardizer fix categories) had no detector at all. Added three new detectors: - ``_detect_inconsistent_phone_format``: nine phone-format regexes (plain-10, US paren / dash / dot / space, +country, extension, intl plus). Fires when a column is ≥35% phone-shaped AND mixes ≥2 formats. - ``_detect_inconsistent_currency_format``: thirteen currency regexes covering US ($1,234.56 / $1234.56), EU (€1.234,56), India lakh notation, Swiss apostrophe, trailing-symbol, parens-negative, prefix-currency-code, suffix-currency-code, and negative variants. Same fire criteria as phone. - ``_detect_inconsistent_boolean_format``: column is ≥80% boolean tokens (yes/no/y/n/true/false/1/0) AND uses ≥3 distinct surface forms (e.g. yes / Y / true / 1 mixed together). Verified on every file in ``test-cases/format-cleaner-corpus/``: 24_format_dates, 25_format_phones, 29_format_currencies all now produce a format-standardizer Finding. The integration test file flags all three. The threshold loosening (from 50% to 35% of values format-shaped) is still strict enough to avoid false-positives on free-text comment columns where a few cells happen to look phone- or date-shaped. (2) The "Open <Tool>" jump links blended into the page. Reported: the per-tool jump links inside the home findings panel were too subtle to notice. Replaced ``st.page_link`` with ``st.button(type="primary")`` so the buttons render in Streamlit's primary-action red colour, matching the "Clean Text" / "Find Duplicates" / etc. run buttons. Click handler delegates to ``st.switch_page(page_slug)`` so it's still a soft in-app navigation (no full reload). 2220 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1406,10 +1406,18 @@ def render_findings_panel(findings, *, header: str | None = None) -> None:
|
||||
_render_one_finding(f)
|
||||
page_slug = _tool_page_slug(tool_id)
|
||||
if page_slug:
|
||||
# Streamlit resolves page paths relative to the entrypoint
|
||||
# (src/gui/app.py), so a leading ``src/gui/`` would point
|
||||
# outside the allowed page tree on Windows.
|
||||
st.page_link(page_slug, label=_t("findings.open_tool", tool=name))
|
||||
# Render as a primary (red) ``st.button`` rather than the
|
||||
# subtle ``st.page_link`` we used before — the previous
|
||||
# rendering blended into the page, making the per-tool
|
||||
# jump non-obvious. The button triggers ``st.switch_page``
|
||||
# so navigation is still a soft switch (no full reload).
|
||||
if st.button(
|
||||
_t("findings.open_tool", tool=name),
|
||||
key=f"_findings_open_{tool_id}",
|
||||
type="primary",
|
||||
use_container_width=False,
|
||||
):
|
||||
st.switch_page(page_slug)
|
||||
|
||||
if untargeted:
|
||||
with st.expander(
|
||||
|
||||
Reference in New Issue
Block a user