fix: test suite — seed reset, FK mappings, standalone focus tests

- Change all seed inserts from ON CONFLICT DO NOTHING to DO UPDATE SET
  so seeds always reset to canonical values between test runs
- Add meeting_id, decision_id, link_id to FK_FIELD_MAP in form_factory
- Add item_ids, direction, label, content to NAME_PATTERNS
- Add TestStandaloneFocusItems (7 tests): quick-add, edit, project tab
- Add TestFocusConversion (6 tests): convert to task/note/link/list item
- Add focus_standalone seed with fixture
- Update focus_page_loads test for permanent (non-date-scoped) items
- All 398 tests passing

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-03-04 03:08:53 +00:00
parent a61248b67d
commit a2183af6e2
3 changed files with 386 additions and 33 deletions

View File

@@ -33,6 +33,7 @@ SEED_IDS = {
"process_run": "a0000000-0000-0000-0000-000000000012",
"time_budget": "a0000000-0000-0000-0000-000000000013",
"file": "a0000000-0000-0000-0000-000000000014",
"focus_standalone": "a0000000-0000-0000-0000-000000000015",
}
@@ -93,85 +94,98 @@ def all_seeds(sync_conn):
cur.execute("""
INSERT INTO domains (id, name, color, description, sort_order, is_deleted, created_at, updated_at)
VALUES (%s, 'Test Domain', '#FF5733', 'Auto test domain', 0, false, now(), now())
ON CONFLICT (id) DO NOTHING
ON CONFLICT (id) DO UPDATE SET name='Test Domain', color='#FF5733', description='Auto test domain',
sort_order=0, is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["domain"],))
# Area
cur.execute("""
INSERT INTO areas (id, name, domain_id, description, status, sort_order, is_deleted, created_at, updated_at)
VALUES (%s, 'Test Area', %s, 'Auto test area', 'active', 0, false, now(), now())
ON CONFLICT (id) DO NOTHING
""", (d["area"], d["domain"]))
ON CONFLICT (id) DO UPDATE SET name='Test Area', domain_id=%s, description='Auto test area',
status='active', sort_order=0, is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["area"], d["domain"], d["domain"]))
# Project
cur.execute("""
INSERT INTO projects (id, name, domain_id, area_id, description, status, priority, sort_order, is_deleted, created_at, updated_at)
VALUES (%s, 'Test Project', %s, %s, 'Auto test project', 'active', 2, 0, false, now(), now())
ON CONFLICT (id) DO NOTHING
""", (d["project"], d["domain"], d["area"]))
ON CONFLICT (id) DO UPDATE SET name='Test Project', domain_id=%s, area_id=%s,
description='Auto test project', status='active', priority=2, sort_order=0,
is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["project"], d["domain"], d["area"], d["domain"], d["area"]))
# Task (status='open' matches DB default, not 'todo')
cur.execute("""
INSERT INTO tasks (id, title, domain_id, project_id, description, priority, status, sort_order, is_deleted, created_at, updated_at)
VALUES (%s, 'Test Task', %s, %s, 'Auto test task', 2, 'open', 0, false, now(), now())
ON CONFLICT (id) DO NOTHING
""", (d["task"], d["domain"], d["project"]))
ON CONFLICT (id) DO UPDATE SET title='Test Task', domain_id=%s, project_id=%s,
description='Auto test task', priority=2, status='open', sort_order=0,
is_deleted=false, deleted_at=NULL, completed_at=NULL, updated_at=now()
""", (d["task"], d["domain"], d["project"], d["domain"], d["project"]))
# Contact
cur.execute("""
INSERT INTO contacts (id, first_name, last_name, company, email, is_deleted, created_at, updated_at)
VALUES (%s, 'Test', 'Contact', 'TestCorp', 'test@example.com', false, now(), now())
ON CONFLICT (id) DO NOTHING
ON CONFLICT (id) DO UPDATE SET first_name='Test', last_name='Contact', company='TestCorp',
email='test@example.com', is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["contact"],))
# Note
cur.execute("""
INSERT INTO notes (id, title, domain_id, body, content_format, is_deleted, created_at, updated_at)
VALUES (%s, 'Test Note', %s, 'Test body content', 'markdown', false, now(), now())
ON CONFLICT (id) DO NOTHING
""", (d["note"], d["domain"]))
ON CONFLICT (id) DO UPDATE SET title='Test Note', domain_id=%s, body='Test body content',
content_format='markdown', is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["note"], d["domain"], d["domain"]))
# Meeting
cur.execute("""
INSERT INTO meetings (id, title, meeting_date, status, is_deleted, created_at, updated_at)
VALUES (%s, 'Test Meeting', '2025-06-15', 'scheduled', false, now(), now())
ON CONFLICT (id) DO NOTHING
ON CONFLICT (id) DO UPDATE SET title='Test Meeting', meeting_date='2025-06-15',
status='scheduled', is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["meeting"],))
# Decision
cur.execute("""
INSERT INTO decisions (id, title, status, impact, is_deleted, created_at, updated_at)
VALUES (%s, 'Test Decision', 'decided', 'high', false, now(), now())
ON CONFLICT (id) DO NOTHING
ON CONFLICT (id) DO UPDATE SET title='Test Decision', status='decided', impact='high',
is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["decision"],))
# Appointment
cur.execute("""
INSERT INTO appointments (id, title, start_at, end_at, all_day, is_deleted, created_at, updated_at)
VALUES (%s, 'Test Appointment', '2025-06-15 10:00:00', '2025-06-15 11:00:00', false, false, now(), now())
ON CONFLICT (id) DO NOTHING
ON CONFLICT (id) DO UPDATE SET title='Test Appointment', start_at='2025-06-15 10:00:00',
end_at='2025-06-15 11:00:00', all_day=false, is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["appointment"],))
# Link folder
cur.execute("""
INSERT INTO link_folders (id, name, is_deleted, created_at, updated_at)
VALUES (%s, 'Test Folder', false, now(), now())
ON CONFLICT (id) DO NOTHING
ON CONFLICT (id) DO UPDATE SET name='Test Folder', is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["link_folder"],))
# List
cur.execute("""
INSERT INTO lists (id, name, domain_id, project_id, list_type, is_deleted, created_at, updated_at)
VALUES (%s, 'Test List', %s, %s, 'checklist', false, now(), now())
ON CONFLICT (id) DO NOTHING
""", (d["list"], d["domain"], d["project"]))
ON CONFLICT (id) DO UPDATE SET name='Test List', domain_id=%s, project_id=%s,
list_type='checklist', is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["list"], d["domain"], d["project"], d["domain"], d["project"]))
# Link
cur.execute("""
INSERT INTO links (id, label, url, domain_id, is_deleted, created_at, updated_at)
VALUES (%s, 'Test Link', 'https://example.com', %s, false, now(), now())
ON CONFLICT (id) DO NOTHING
""", (d["link"], d["domain"]))
ON CONFLICT (id) DO UPDATE SET label='Test Link', url='https://example.com', domain_id=%s,
is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["link"], d["domain"], d["domain"]))
# Link folder junction
cur.execute("""
@@ -183,15 +197,26 @@ def all_seeds(sync_conn):
cur.execute("""
INSERT INTO capture (id, raw_text, processed, is_deleted, created_at, updated_at)
VALUES (%s, 'Test capture item', false, false, now(), now())
ON CONFLICT (id) DO NOTHING
ON CONFLICT (id) DO UPDATE SET raw_text='Test capture item', processed=false,
is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["capture"],))
# Daily focus
# Daily focus (task-linked)
cur.execute("""
INSERT INTO daily_focus (id, task_id, focus_date, completed, created_at, updated_at)
VALUES (%s, %s, CURRENT_DATE, false, now(), now())
ON CONFLICT (id) DO NOTHING
""", (d["focus"], d["task"]))
ON CONFLICT (id) DO UPDATE SET task_id=%s, focus_date=CURRENT_DATE, completed=false,
is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["focus"], d["task"], d["task"]))
# Daily focus (standalone text item)
cur.execute("""
INSERT INTO daily_focus (id, focus_date, completed, title, domain_id, project_id, created_at, updated_at)
VALUES (%s, CURRENT_DATE, false, 'Test Standalone Focus', %s, %s, now(), now())
ON CONFLICT (id) DO UPDATE SET focus_date=CURRENT_DATE, completed=false,
title='Test Standalone Focus', domain_id=%s, project_id=%s,
is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["focus_standalone"], d["domain"], d["project"], d["domain"], d["project"]))
# Junction table seeds for contact tabs
cur.execute("""
@@ -215,29 +240,33 @@ def all_seeds(sync_conn):
cur.execute("""
INSERT INTO processes (id, name, process_type, status, category, is_deleted, created_at, updated_at)
VALUES (%s, 'Test Process', 'checklist', 'active', 'Testing', false, now(), now())
ON CONFLICT (id) DO NOTHING
ON CONFLICT (id) DO UPDATE SET name='Test Process', process_type='checklist', status='active',
category='Testing', is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["process"],))
# Process step
cur.execute("""
INSERT INTO process_steps (id, process_id, title, instructions, sort_order, is_deleted, created_at, updated_at)
VALUES (%s, %s, 'Test Step', 'Do the thing', 0, false, now(), now())
ON CONFLICT (id) DO NOTHING
""", (d["process_step"], d["process"]))
ON CONFLICT (id) DO UPDATE SET process_id=%s, title='Test Step', instructions='Do the thing',
sort_order=0, is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["process_step"], d["process"], d["process"]))
# Process run
cur.execute("""
INSERT INTO process_runs (id, process_id, title, status, process_type, task_generation, is_deleted, created_at, updated_at)
VALUES (%s, %s, 'Test Run', 'not_started', 'checklist', 'all_at_once', false, now(), now())
ON CONFLICT (id) DO NOTHING
""", (d["process_run"], d["process"]))
ON CONFLICT (id) DO UPDATE SET process_id=%s, title='Test Run', status='not_started',
process_type='checklist', task_generation='all_at_once', is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["process_run"], d["process"], d["process"]))
# Time budget
cur.execute("""
INSERT INTO time_budgets (id, domain_id, weekly_hours, effective_from, is_deleted, created_at, updated_at)
VALUES (%s, %s, 10, CURRENT_DATE, false, now(), now())
ON CONFLICT (id) DO NOTHING
""", (d["time_budget"], d["domain"]))
ON CONFLICT (id) DO UPDATE SET domain_id=%s, weekly_hours=10, effective_from=CURRENT_DATE,
is_deleted=false, deleted_at=NULL, updated_at=now()
""", (d["time_budget"], d["domain"], d["domain"]))
# File (create a dummy file on disk for download/serve tests)
import os
@@ -275,6 +304,7 @@ def all_seeds(sync_conn):
cur.execute("DELETE FROM process_runs WHERE id = %s", (d["process_run"],))
cur.execute("DELETE FROM process_steps WHERE id = %s", (d["process_step"],))
cur.execute("DELETE FROM processes WHERE id = %s", (d["process"],))
cur.execute("DELETE FROM daily_focus WHERE id = %s", (d["focus_standalone"],))
cur.execute("DELETE FROM daily_focus WHERE id = %s", (d["focus"],))
cur.execute("DELETE FROM capture WHERE id = %s", (d["capture"],))
cur.execute("DELETE FROM folder_links WHERE link_id = %s", (d["link"],))
@@ -350,3 +380,7 @@ def seed_list(all_seeds):
@pytest.fixture(scope="session")
def seed_appointment(all_seeds):
return {"id": all_seeds["appointment"], "title": "Test Appointment"}
@pytest.fixture(scope="session")
def seed_focus_standalone(all_seeds):
return {"id": all_seeds["focus_standalone"], "title": "Test Standalone Focus"}